Skip to content

fix Slow Pipeline #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix Slow Pipeline #1210

wants to merge 1 commit into from

Conversation

hiitesh1127
Copy link
Contributor

@hiitesh1127 hiitesh1127 commented Oct 18, 2022 •
edited by gitpod-io bot
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@hiitesh1127
Copy link
Contributor Author

hiitesh1127 commented Oct 18, 2022 •
edited
Loading

As I was creating PR, I noticed that some tests caused the pipeline to take at least 30 minutes to run, and after investigating, I fixed it so that they now run in less than a minute.

Here are my previous PR's, please check the pipeline running duration once for this PR's
#1208
#1209
and please review it also 😅

@hiitesh1127 hiitesh1127 mentioned this pull request Oct 19, 2022
Closed
12 tasks
appgurueu
appgurueu reviewed Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a (proper) fix at #1194; disabling the Project Euler condition check is not quite the way to go...

@appgurueu appgurueu closed this Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu left review comments

@raklaptudirm raklaptudirm Awaiting requested review from raklaptudirm raklaptudirm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiitesh1127 @appgurueu